119 lines
8.5 KiB
Markdown
119 lines
8.5 KiB
Markdown
# Weekly Review — Week of April 18, 2026
|
||
|
||
---
|
||
|
||
### ✅ Moved Forward
|
||
|
||
**TP transition landed cleanly — iOS: Demo tracker blocking after chat in onboarding (`gid:1213551050320249`)**
|
||
Kick-off ran Tue Apr 21 at O-N Weekly Meeting. Alex posted detailed kick-off notes Apr 21 (parallel Suggested Site List reeval, subscription promo open question). Kick-off task `gid:1213551072611251` closed same day. Alessandro replied Apr 22 with chunking guidance: "try to avoid a unique PR… please divide the work in chunks." PR #4544 already open by end-of-week. Investigation is Day 3, due May 11 — on track.
|
||
|
||
**Pre-Ship-Review opened — iOS AI onboarding for custom product pages (`gid:1214147157456480`)**
|
||
Alex opened the Pre-Ship-Review Apr 23 with 4 concrete implementation questions (AM1–AM4 covering keyboard behavior, upsell flow, subscription screen entry). Alessandro confirmed correct behavior Apr 24. Window due Apr 30, on a 2–5 day track. This is the cleanest artifact authored this week.
|
||
|
||
**Tech Design review depth — iOS AI onboarding (`gid:1213551226650171`)**
|
||
Alessandro's TD got detailed review from Alex (with Sabrina also in). Multi-point dialog Apr 23–24: discussion of CustomProductPage vs OnboardingFlowType, UIInteractionManager separation, Universal Link considerations. Alessandro responded "great questions!" to Alex's structured ST1–ST4 review. Due Apr 27.
|
||
|
||
**Both carried-over CI fires resolved**
|
||
- `gid:1213996660793764` [macOS] GeolocationProviderTests async flakiness — fix PR `gid:1214127380124740` merged, task closed Apr 22.
|
||
- `gid:1214067738586364` PR Check on main (CSS 14.0.0 integration test crash) — Alex fixed by switching DeallocationTests to `data://` URLs rather than real navigations; task closed Apr 21.
|
||
|
||
**Proposal: Rollback `/Applications/DEBUG` install dir (`gid:1214136461142650`)**
|
||
DEBUG rollback proposal landed Apr 22: "Simply setting DEPLOYMENT_LOCATION to NO did the trick." PR #4510 open, CI ✅. Diego reviewed constructively Apr 21. Still waiting on Diego's formal approval — open loop into Monday.
|
||
|
||
**NSException+cxxHandler crash closed (`gid:1214143353966986`)**
|
||
Alex posted root-cause analysis Apr 21 — recursion introduced by Mar/27 CxxHandler modification. Fix landed. Task closed Apr 23.
|
||
|
||
**DMV popup blocking shipped (`gid:1213832268661772`)**
|
||
Triage → PR #4987 to privacy-configuration → task closed Apr 21. Same-day turnaround.
|
||
|
||
**Ashby Hiring Team Member Setup (`gid:1214121856485510`)** — Admin task closed on deadline Apr 23.
|
||
|
||
**Stale top_priority cleanup — FE <> iOS Sync (`gid:1213472659952301`)** — Flagged in last weekly review as stalled 4+ weeks. Closed Apr 21.
|
||
|
||
**Minor closures** (all Apr 20): Integration_Tests_App_Store.HistoryIntegrationTests (confirmed fixed by PR #4442), duck.ai capitalization fix, autofill HomeAssistant triage, DEBUG rollback admin, Next TP Mar/30 admin, Decommission Asana personal-automation token, QWD Apr 15–17 wrap-up.
|
||
|
||
**No Ship Reviews closed this week.** Only the Pre-Ship-Review was opened.
|
||
**No Tech Designs reached LGTM / approved state.** Alex gave review on Alessandro's TD; it's still in Draft.
|
||
**No rotations completed.** (macOS Weekly Maintenance DRI is scheduled for May 22.)
|
||
|
||
---
|
||
|
||
### 🔄 Didn't Move
|
||
|
||
**[OVERDUE +2d, 17 days since original ping] [DRI] — PR Check testWhenTabWithConnectionLost… (`gid:1213975496167929`)**
|
||
Sam S assigned Apr 8. Zero human activity on the task itself. Third automated reminder fired Apr 23. Carried through two weekly plans. Kept getting displaced by higher-urgency items — Sam's task never bubbled because no one external was chasing it.
|
||
*Next step:* Reproduce + post root cause OR apply flaky label and notify Sam S. Even a 2-line "investigating, ETA Monday" would reset the clock.
|
||
|
||
**[OVERDUE +2d] [DRI] — Text selection in the address bar (`gid:1214071796247142`)**
|
||
PR #4548 in flight (CI 🔴) but the Asana task has zero status update for Alessandro. Work is happening in GitHub, but Asana comms didn't follow. Silent motion still looks like silence to the OOO-coverage stakeholder.
|
||
*Next step:* Post status comment on Asana linking PR #4548 + stabilize CI.
|
||
|
||
**[STALLED] [AUTHOR] — Readiness Self-Reflection for Potential Project Advisor (`gid:1210386994396212`)**
|
||
Carried as "at latest Friday before weekly review." Today was the deadline; will slide.
|
||
*Next step:* Protect a 30-min slot Monday. If that slot dies, acknowledge the slip to Dominik in the 1:1.
|
||
|
||
**[STALLED] — Follow-up: Inline Text Images to TypingTextAnimation (`gid:1214040804696193`)**
|
||
Logged Apr 14 as post-ship follow-up. Still no due date, no activity. Mentioned in last weekly review with same status.
|
||
*Next step:* Set a concrete due date or move to a sprint. Not doing this twice in a row is how it disappears.
|
||
|
||
**[OVERDUE +7d] — Pinned tab opens link in background tab (`gid:1214038885921128`)**
|
||
Alessandro assigned Apr 13 with a re-assign offer. Due Apr 17. Not touched.
|
||
*Next step:* Take it with an ETA or give it back. Two weeks silent is past the polite limit.
|
||
|
||
---
|
||
|
||
### 🔗 Open Loops Carrying Forward
|
||
|
||
**Pre-Ship-Review in progress** — `gid:1214147157456480` (iOS AI onboarding). Alex is author/DRI. AM1 still open. Window runs to Apr 28–30.
|
||
|
||
**Tech Design awaiting Alex's final call** — `gid:1213551226650171`. Due Apr 27. Alex is reviewer; Alessandro addressed ST-series feedback. Needs re-review → approve or final comments Monday.
|
||
|
||
**PR reviews Alex owns or is waiting on:**
|
||
- PR #4510 DEBUG rollback — CI ✅, Diego review outstanding
|
||
- PR #4999 privacy-configuration (Remove autocompleteTabs) — needs config-team approver
|
||
- PRs #4544 / #4548 / #4541 — CI 🔴 (new: #4541 pinned tabs, not yet triaged)
|
||
- PRs #4482 / #4483 / #4530 — CI ✅, waiting on reviewers
|
||
- Tom Strba combinedPermissionView PR `gid:1214121879880035` — review window passed; slides to Monday with a courtesy Slack
|
||
|
||
**Delegated tasks overdue:** Anh Do (DBP assertionFailure, 4 months) and Deepankar (Login autofill, 5 months) — pinged daily in briefs, never actioned. Need a 2-min ping or explicit close/archive decision Monday.
|
||
|
||
**Incidents without postmortem** — None visible.
|
||
**PFRs awaiting decision summary** — None visible.
|
||
|
||
**AFK handoff unfinished** — Alex's AFK May 1–8 is 7 days away. PRs that need a reviewer nudge before handoff: #4482, #4483, #4510, #4530. Not addressed this week.
|
||
|
||
---
|
||
|
||
### 📅 Next Week Setup
|
||
|
||
**TP Suggestion: iOS: Demo tracker blocking after chat in onboarding (`gid:1213551050320249`)** — already the active TP, due May 11. PR #4544 open. No reason to switch — this is the right call. Goal for week: at least one chunk of #4544 split/reviewed/merged, CI green.
|
||
|
||
**Rotation:** None active, none starting.
|
||
|
||
**OOO watch:**
|
||
- **Alessandro AFK Mon Apr 27** (Public Holiday) — notable because he's TP project advisor + replying to Pre-Ship-Review + owns the iOS AI onboarding TD. Alessandro-blocking questions should land Tue, not Mon.
|
||
- **Alex AFK May 1–8** (`gid:1212694796293417`) — 7 days away. Handoff brainstorm needed this week.
|
||
|
||
**1:1 with Dominik — Mon Apr 28** (agenda `gid:1214157855537862`). Items to bring:
|
||
- TP kick-off landed clean; Alessandro's chunking feedback being applied
|
||
- Pre-Ship-Review opened on schedule for iOS AI onboarding
|
||
- Carried career item: Advisor Readiness — acknowledge slip, commit to concrete slot
|
||
- AFK May 1–8 handoff plan
|
||
- Possible discussion: 3-week pattern of OVERDUE CI tasks (testWhenTabWithConnectionLost specifically) — structural fix vs. more discipline
|
||
|
||
**Standing meetings:** Mon Apr 27 O-L Weekly; Tue Apr 28 Apple Weekly + O-N Weekly back-to-back; Mon Apr 28 Dominik 1:1.
|
||
|
||
---
|
||
|
||
### 🏆 Wins
|
||
|
||
1. **Clean TP handoff: Toggle Screen → Demo tracker blocking.** Two weeks ago this was "next TP"; this week the kick-off ran, notes posted, PR #4544 opened, and Alessandro's chunking guidance already internalized. The transition from shipped-project to next-TP-investigating happened without a dead-air week.
|
||
|
||
2. **Both carried CI fires killed, plus a clean root-cause on the NSException crash.** Geolocation flakiness (PR merged), CSS 14.0.0 integration test crash (DeallocationTests → `data://`), and NSException+cxxHandler recursion (traced back to the Mar/27 change) — three technically distinct issues resolved with concrete fixes, not just closures.
|
||
|
||
3. **Pre-Ship-Review opened with actually useful questions.** AM1–AM4 aren't form-filling — they're real implementation judgment calls (keyboard-visible upsell flow, subscription screen entry). This is the kind of artifact that shows up well at the next performance cycle.
|
||
|
||
---
|
||
|
||
Saved to `/Users/admin/Developer/personal-os/briefs/weekly/2026-04-24.md`.
|