Files
obsidian-vault/personal/projects/personal-os/personal-os-evidence/2026-11-18/source-material-code-review.json
T

153 lines
7.4 KiB
JSON

{
"work_id": "1215438194342413",
"pr": "duckduckgo/apple-browsers#6791",
"source_id": "pr-code:duckduckgo/apple-browsers#6791",
"source_hash": "0d5c887f2dcdebe5fb62699864c35fedf71ecdae97f3a6afa82619ce14666901",
"head_sha": "6ca9bae818daff76e29ada04ee2be817d2b2069c",
"base_sha": "e6c6353dea9f1266e0055d7a564581bd7082c322",
"changed_files_reviewed": 5,
"patch_bytes": 14718,
"facts": [
{
"id": "last-menu-item",
"statement": "The patch adds the AI Settings item after the existing Delete All Chats entry.",
"evidence": [
{
"source_id": "pr-code:duckduckgo/apple-browsers#6791",
"source_hash": "0d5c887f2dcdebe5fb62699864c35fedf71ecdae97f3a6afa82619ce14666901",
"head_sha": "6ca9bae818daff76e29ada04ee2be817d2b2069c",
"blob_sha": "f4c5ee0b2524ad7999b908324000e48e573e1455",
"pointer": "/files/2/patch",
"start": 1180,
"end": 1207,
"quote": "addItem(openAISettingsItem)",
"path": "macOS/DuckDuckGo/Menus/AIChatMenu.swift",
"line_at_head": 189,
"url": "https://github.com/duckduckgo/apple-browsers/blob/6ca9bae818daff76e29ada04ee2be817d2b2069c/macOS/DuckDuckGo/Menus/AIChatMenu.swift#L189"
}
]
},
{
"id": "injected-action",
"statement": "The menu click delegates to the injected openAISettings action.",
"evidence": [
{
"source_id": "pr-code:duckduckgo/apple-browsers#6791",
"source_hash": "0d5c887f2dcdebe5fb62699864c35fedf71ecdae97f3a6afa82619ce14666901",
"head_sha": "6ca9bae818daff76e29ada04ee2be817d2b2069c",
"blob_sha": "f4c5ee0b2524ad7999b908324000e48e573e1455",
"pointer": "/files/2/patch",
"start": 1428,
"end": 1452,
"quote": "actions.openAISettings()",
"path": "macOS/DuckDuckGo/Menus/AIChatMenu.swift",
"line_at_head": 315,
"url": "https://github.com/duckduckgo/apple-browsers/blob/6ca9bae818daff76e29ada04ee2be817d2b2069c/macOS/DuckDuckGo/Menus/AIChatMenu.swift#L315"
}
]
},
{
"id": "native-settings-route",
"statement": "The default action requests the native AI Chat settings pane. This is a code-path observation; the app was not launched.",
"evidence": [
{
"source_id": "pr-code:duckduckgo/apple-browsers#6791",
"source_hash": "0d5c887f2dcdebe5fb62699864c35fedf71ecdae97f3a6afa82619ce14666901",
"head_sha": "6ca9bae818daff76e29ada04ee2be817d2b2069c",
"blob_sha": "f4c5ee0b2524ad7999b908324000e48e573e1455",
"pointer": "/files/2/patch",
"start": 1911,
"end": 1975,
"quote": "windowControllersManager.showTab(with: .settings(pane: .aiChat))",
"path": "macOS/DuckDuckGo/Menus/AIChatMenu.swift",
"line_at_head": 412,
"url": "https://github.com/duckduckgo/apple-browsers/blob/6ca9bae818daff76e29ada04ee2be817d2b2069c/macOS/DuckDuckGo/Menus/AIChatMenu.swift#L412"
}
]
},
{
"id": "copy-adjustment",
"statement": "The patch changes the relevant English settings captions to AI Settings in application and NewTabPage localizable declarations; the changed translation entries are visible in the diff.",
"evidence": [
{
"source_id": "pr-code:duckduckgo/apple-browsers#6791",
"source_hash": "0d5c887f2dcdebe5fb62699864c35fedf71ecdae97f3a6afa82619ce14666901",
"head_sha": "6ca9bae818daff76e29ada04ee2be817d2b2069c",
"blob_sha": "240141c8d3059f3a0dff12e56adf1274b1c896df",
"pointer": "/files/0/patch",
"start": 882,
"end": 902,
"quote": "value: \"AI Settings\"",
"path": "macOS/DuckDuckGo/Common/Localizables/UserText.swift",
"line_at_head": 747,
"url": "https://github.com/duckduckgo/apple-browsers/blob/6ca9bae818daff76e29ada04ee2be817d2b2069c/macOS/DuckDuckGo/Common/Localizables/UserText.swift#L747"
},
{
"source_id": "pr-code:duckduckgo/apple-browsers#6791",
"source_hash": "0d5c887f2dcdebe5fb62699864c35fedf71ecdae97f3a6afa82619ce14666901",
"head_sha": "6ca9bae818daff76e29ada04ee2be817d2b2069c",
"blob_sha": "96bbe12e081abddcebf1f521b1521ad419169c9d",
"pointer": "/files/3/patch",
"start": 1032,
"end": 1052,
"quote": "value: \"AI Settings\"",
"path": "macOS/LocalPackages/NewTabPage/Sources/NewTabPage/internal/UserText.swift",
"line_at_head": 34,
"url": "https://github.com/duckduckgo/apple-browsers/blob/6ca9bae818daff76e29ada04ee2be817d2b2069c/macOS/LocalPackages/NewTabPage/Sources/NewTabPage/internal/UserText.swift#L34"
}
]
},
{
"id": "test-definitions",
"statement": "The patch adds action and navigation test definitions and an assertion that the settings item is last. Execution of these tests is not established by reading their definitions.",
"evidence": [
{
"source_id": "pr-code:duckduckgo/apple-browsers#6791",
"source_hash": "0d5c887f2dcdebe5fb62699864c35fedf71ecdae97f3a6afa82619ce14666901",
"head_sha": "6ca9bae818daff76e29ada04ee2be817d2b2069c",
"blob_sha": "2709d802b22c819c5f73ca5bf29eeedef822e08a",
"pointer": "/files/4/patch",
"start": 1369,
"end": 1411,
"quote": "func testOpenAISettingsTappedCallsAction()",
"path": "macOS/UnitTests/AIChat/AIChatMenuTests.swift",
"line_at_head": 276,
"url": "https://github.com/duckduckgo/apple-browsers/blob/6ca9bae818daff76e29ada04ee2be817d2b2069c/macOS/UnitTests/AIChat/AIChatMenuTests.swift#L276"
},
{
"source_id": "pr-code:duckduckgo/apple-browsers#6791",
"source_hash": "0d5c887f2dcdebe5fb62699864c35fedf71ecdae97f3a6afa82619ce14666901",
"head_sha": "6ca9bae818daff76e29ada04ee2be817d2b2069c",
"blob_sha": "2709d802b22c819c5f73ca5bf29eeedef822e08a",
"pointer": "/files/4/patch",
"start": 1711,
"end": 1771,
"quote": "func testDefaultOpenAISettingsActionOpensAIChatPreferences()",
"path": "macOS/UnitTests/AIChat/AIChatMenuTests.swift",
"line_at_head": 283,
"url": "https://github.com/duckduckgo/apple-browsers/blob/6ca9bae818daff76e29ada04ee2be817d2b2069c/macOS/UnitTests/AIChat/AIChatMenuTests.swift#L283"
},
{
"source_id": "pr-code:duckduckgo/apple-browsers#6791",
"source_hash": "0d5c887f2dcdebe5fb62699864c35fedf71ecdae97f3a6afa82619ce14666901",
"head_sha": "6ca9bae818daff76e29ada04ee2be817d2b2069c",
"blob_sha": "2709d802b22c819c5f73ca5bf29eeedef822e08a",
"pointer": "/files/4/patch",
"start": 1116,
"end": 1180,
"quote": "XCTAssertEqual(titles.last, UserText.aiChatChromeOpenAISettings)",
"path": "macOS/UnitTests/AIChat/AIChatMenuTests.swift",
"line_at_head": 73,
"url": "https://github.com/duckduckgo/apple-browsers/blob/6ca9bae818daff76e29ada04ee2be817d2b2069c/macOS/UnitTests/AIChat/AIChatMenuTests.swift#L73"
}
]
}
],
"claim_scope": "explicit_changed_code_only",
"runtime_app_tested": false,
"repository_tests_executed": false,
"whole_file_or_repository_behavior_verified": false,
"frozen_evaluation_input_modified": false,
"personal_credit_for_alex_established": false
}