git_admin/obsidian-vault
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[2026-06-26] eagle: work/tech-design/data-url-new-tab-frame-load-interrupted.md

Browse Source
This commit is contained in:
Alexey Martemyanov
2026-06-26 14:44:46 +06:00
parent 6e8a954e5f
commit ed3574fbb0
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
work/tech-design/data-url-new-tab-frame-load-interrupted.md
+4 -1
View File
@@ -140,7 +140,10 @@ This prevents `createChildWebView` from returning a `WKWebView` to WebKit at all
- Open a page that calls `window.open('javascript:void(0)', '_blank')`. Verify unchanged — still blocked.
- Normal `window.open('https://example.com', '_blank')` continues to open in a new tab.
- **Existing test coverage:** `PopupHandlingTabExtensionTests` should cover the `javascript:` scheme guard; extend to cover `data:` scheme.
- **New unit tests needed:** `PopupHandlingTabExtensionTests` currently has no tests for the navigational-scheme guard in `createChildWebView`. Tests should be added to verify:
- `createWebView` returns `nil` for `javascript:` URLs.
- `createWebView` returns `nil` for `data:` URLs.
- `createWebView` returns a non-nil `WKWebView` for HTTPS URLs when popup permission is granted.
- **Tab content state test:** verify that after a navigation to a `data:` URL is interrupted, `Tab.content` reflects the previous committed URL (or `.none`) rather than the blocked `data:` URL.