git_admin/obsidian-vault
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[2026-05-15] obsidian-vault-strategy: remove hardcoded files, add 12 enrichment use cases

Browse Source
This commit is contained in:
Alexey Martemyanov
2026-05-15 20:45:57 +06:00
parent c4bee9e5ad
commit b17da7efff
3 changed files with 80 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files
work/wiki/apple-browsers/chat-path-onboarding-tracker-blocking.md
+18 -4
View File
@@ -360,13 +360,15 @@ All resolved on GitHub. Fixed in later commits on the `#4544` branch.
---
### 🔴 PR #4664 — Bugbot (RebrandedContextualOnboardingDialogs+SubscriptionPromo.swift:101): Dismiss button appears on standard path
### ✅ [Resolved] PR #4664 — Bugbot (RebrandedContextualOnboardingDialogs+SubscriptionPromo.swift:101): Dismiss button appears on chat path
**Source:** Bugbot on PR #4664, `RebrandedContextualOnboardingDialogs+SubscriptionPromo.swift:101`
**Issue:** Dismiss button is rendered unconditionally, but should only appear on the chat path.
**Issue:** X dismiss button rendered unconditionally on subscription promo dialog; should be hidden on chat path (user should use the dedicated CTA, not escape via X).
**State:** 🔴 [OPEN] on GitHub. Needs a chat-path guard on the dismiss button.
**Fix:** `onManualDismiss` is `(() -> Void)?` in `OnboardingSubscriptionPromoDialog` (line 40, comment: "When `nil` the X dismiss button is hidden (e.g. chat-path onboarding)"). `RebrandedNewTabDaxDialogFactory` passes `nil` when `isChatPath`. Already in code — Bugbot is outdated.
**State:** ✅ Already fixed. GitHub thread status unknown.
---
@@ -504,7 +506,7 @@ All resolved on GitHub. Fixed in later commits on the `#4544` branch.
---
### 🟠 PR #4855 — Alessandro (line 450): Add `!restorePromptHandler.isEligibleForRestorePrompt()` to the returning-user guard
### 🔴 PR #4855 — Alessandro (line 450): Add `!restorePromptHandler.isEligibleForRestorePrompt()` to the returning-user guard
**Source:** [Alessandro May 15 review on PR #4855](https://github.com/duckduckgo/apple-browsers/pull/4855), `OnboardingIntroViewModel.swift:450`. Also referenced in [Alessandro's May 15 Asana comment](https://app.asana.com/1/137249556945/task/1214348462471176/comment/1214794564106665).
@@ -516,6 +518,18 @@ All resolved on GitHub. Fixed in later commits on the `#4544` branch.
---
### 🟠 PR #4855 — Legacy factory: dismiss button shown unconditionally on visit-site dialog
**Source:** Observed during SR feedback pass. Parity issue with `RebrandedNewTabDaxDialogFactory`, which already suppresses the X button on chat path.
**Issue:** `NewTabDaxDialogFactory.createSubsequentDialog` always passed `manualDismissAction` as a non-optional closure to `OnboardingTryVisitingSiteDialog`, so `DaxDialogView` always rendered the X dismiss button — including on the chat path where the user must pick a site and should not be able to escape.
**Fix:** `manualDismissAction` changed to `(() -> Void)? = isChatPath ? nil : { … }`. `OnboardingTryVisitingSiteDialog.onManualDismiss` made `(() -> Void)?` so `DaxDialogView`'s `ifLet(onManualDismiss)` skips the button when `nil`. `ContextualDaxDialogsFactory` (in-browser overlay, always correct to show dismiss) unaffected.
**State:** 🟠 Fix in working tree, NOT committed.
---
### ✅ DEAD-1 — `setChatPathVisitSiteControlsLocked` in `MainViewController+DuckAIExperiment.swift` deleted
**Source:** Callers removed as part of PR #4855 Alessandro (line 477) fix above.