diff --git a/work/wiki/apple-browsers/chat-path-onboarding-tracker-blocking.md b/work/wiki/apple-browsers/chat-path-onboarding-tracker-blocking.md index 4c03205d..67ce5005 100644 --- a/work/wiki/apple-browsers/chat-path-onboarding-tracker-blocking.md +++ b/work/wiki/apple-browsers/chat-path-onboarding-tracker-blocking.md @@ -326,13 +326,17 @@ All resolved on GitHub. Fixed in later commits on the `#4544` branch. --- -### 🔴 PR #4591 — Bugbot (RebrandedNewTabDaxDialogFactory.swift): `onPresented` passes `false` but sheet was shown +### ✅ [Resolved] PR #4591 — Bugbot (RebrandedNewTabDaxDialogFactory.swift): `onPresented` passes `false` but sheet was shown **Source:** Bugbot on PR #4591, `RebrandedNewTabDaxDialogFactory.swift` -**Issue:** `onPresented` closure is called with `false` despite the subscription sheet having been shown, leading to incorrect state tracking. +**Issue (Bugbot):** `onPresented` closure calls `onDismiss(false)` despite the subscription sheet having been shown. -**State:** 🔴 [OPEN] on GitHub. Needs fix. +**Why it's a false positive:** The `Bool` parameter is `activateSearch`, not a "was shown" flag. `false` = "don't activate the search bar after dismissal" (user is heading to the subscription flow). `true` = "activate search" (user tapped Skip). The legacy `NewTabDaxDialogFactory` does the same in its proceed path. The `onPresented` deferral is intentional — avoids an NTP flash by keeping the promo visible until the Settings sheet fully covers it. + +**Fix:** Added inline comment `// activateSearch: false — user is navigating to subscription, not returning to search.` to make the parameter intent explicit. + +**State:** ✅ False positive. Comment added to suppress future confusion. ---