[2026-05-18] business coaching: сессия 1 W20 — лендинг до 20.05, страх публичности как реальный блок
This commit is contained in:
Alexey Martemyanov
@@ -217,7 +217,7 @@ All resolved on GitHub. Fixed in later commits on the `#4544` branch.
|
||||
|
||||
**Fix:** Removed `isChatPath` conditional from `NewTabDaxDialogFactory.createFinalDialog` — both factories now always use standard EOJ message + `daxDialogsEndOfJourneyNewTabUnique` pixel. Deleted test `testWhenChatPathEOJState_AndFinalDialogAppears_ThenFiresDuckAIExperimentFinalDialogPixel` (tested dead code); simplified remaining final-dialog tests.
|
||||
|
||||
**State:** ✅ Fixed in `alex/demo-tracker-blocking-onboarding` working tree (2026-05-18). Not yet committed.
|
||||
**State:** ✅ Fixed and committed (2026-05-18). GitHub thread resolved on GitHub.
|
||||
|
||||
---
|
||||
|
||||
@@ -229,7 +229,7 @@ All resolved on GitHub. Fixed in later commits on the `#4544` branch.
|
||||
|
||||
**Fix:** `if contextualOnboardingLogic.chatPathPhase == .trackerToEOJ { delegate?.tabDidRequestNewTab(self) }` in `didTapDismissContextualOnboardingAction` (`TabViewController.swift:4206`).
|
||||
|
||||
**State:** ✅ Fix in `alex/demo-tracker-blocking-onboarding` (landed via PR #4584 merge, 2026-05-18). GitHub thread on PR #4544 still open — needs resolving.
|
||||
**State:** ✅ Fix landed via PR #4584 merge. GitHub thread **resolved** on GitHub.
|
||||
|
||||
---
|
||||
|
||||
@@ -241,7 +241,19 @@ All resolved on GitHub. Fixed in later commits on the `#4544` branch.
|
||||
|
||||
**Fix:** Resolved by removing the dead branch from `NewTabDaxDialogFactory` (see r3234446893 entry above). Both factories now symmetric.
|
||||
|
||||
**State:** ✅ Fixed in `alex/demo-tracker-blocking-onboarding` working tree (2026-05-18). Not yet committed.
|
||||
**State:** ✅ Fixed and committed (2026-05-18). GitHub thread resolved on GitHub.
|
||||
|
||||
---
|
||||
|
||||
### ✅ PR #4544 — Bugbot (r3257196584): Chat-path subscription promo unreachable after EOJ dismissal
|
||||
|
||||
**Source:** [Bugbot r3257196584 on PR #4544](https://github.com/duckduckgo/apple-browsers/pull/4544#discussion_r3257196584), `NewTabPageViewController.swift:355-374` and `DaxDialogs.swift:407-419`.
|
||||
|
||||
**Issue:** In `finishDismissal` (inside `showDuckAIOnboardingCompletionDialog`), `nextHomeScreenMessageNew()` was called while `browsingFinalDialogShown` was still `false`. `peekNextHomeScreenMessageExperiment()` took the chat-path branch (not the `finalDaxDialogSeen` branch) and returned `nil`. The else branch then called `daxDialogsManager.dismiss()` which atomically set `browsingFinalDialogShown = true` and `isDismissed = true`, making `isEnabled = false`. Any subsequent call returned `nil` unconditionally — subscription promo was unreachable.
|
||||
|
||||
**Fix:** Call `setFinalOnboardingDialogSeen()` before `nextHomeScreenMessageNew()` in `finishDismissal`. Added `setFinalOnboardingDialogSeen()` to `NewTabDialogSpecProvider` protocol; added stub to `MockNewTabDialogSpecProvider`.
|
||||
|
||||
**State:** ✅ Fixed and committed (2026-05-18). GitHub thread still **open** — needs resolving.
|
||||
|
||||
---
|
||||
|
||||
@@ -389,23 +401,23 @@ All resolved on GitHub. Fixed in later commits on the `#4544` branch.
|
||||
|
||||
> Threads in GitHub order.
|
||||
|
||||
### 🔴 PR #4668 — Bugbot (OnboardingIntroViewModel.swift:473): Hardcoded debug `return`
|
||||
### ⭕ PR #4668 — Bugbot (OnboardingIntroViewModel.swift:473): Hardcoded debug `return`
|
||||
|
||||
**Source:** Bugbot on PR #4668, `OnboardingIntroViewModel.swift:473`
|
||||
|
||||
**Issue:** A hardcoded `return .treatmentB` debug shortcut bypasses the feature flag in `resolveDuckAIQueryExperimentCohortID()`. Must be removed before shipping.
|
||||
**Issue:** Hardcoded `return .treatmentA` bypasses feature flag in `resolveDuckAIQueryExperimentCohortID()`.
|
||||
|
||||
**State:** 🔴 [OPEN] on GitHub. Same item appears on PR #4855 (Bugbot line 473). Not yet removed on #4668 branch.
|
||||
**State:** ⭕ Removed and pushed on #4668 branch. GitHub thread still open — needs resolving.
|
||||
|
||||
---
|
||||
|
||||
### 🔴 PR #4668 — Bugbot (FeatureFlag.swift:635): Commented-out `Config(...)` line
|
||||
### ⭕ PR #4668 — Bugbot (FeatureFlag.swift:635): Commented-out `Config(...)` line
|
||||
|
||||
**Source:** Bugbot on PR #4668, `FeatureFlag.swift:635`
|
||||
|
||||
**Issue:** `defaultValue: .enabled` override was added to `unifiedToggleInput` for testing, plus the old `// Config(...)` line still sits underneath as dead commented-out code. Both need to be removed before merging.
|
||||
|
||||
**State:** 🔴 Still in code on the `#4668` branch. NOT fixed. GitHub thread NOT resolved.
|
||||
**State:** ⭕ TODO — still in code on `#4668` branch. Deferred until main PR (#4544) is done.
|
||||
|
||||
---
|
||||
|
||||
@@ -415,27 +427,27 @@ All resolved on GitHub. Fixed in later commits on the `#4544` branch.
|
||||
|
||||
**Issue:** Method added to `BrowserChromeDelegate` protocol and implemented, but no caller exists.
|
||||
|
||||
**State:** 🔴 [OPEN] on GitHub. See also BrowserChromeManager item below — same root issue.
|
||||
**State:** 🔴 [OPEN] on GitHub. Deferred until #4544 is done — see BrowserChromeManager item below for full detail.
|
||||
|
||||
---
|
||||
|
||||
### 🔴 PR #4668 — aataraxiaa (FeatureFlag.swift:635): Commented-out config line
|
||||
### ⭕ PR #4668 — aataraxiaa (FeatureFlag.swift:635): Commented-out config line
|
||||
|
||||
**Source:** [aataraxiaa review comment on PR #4668](https://github.com/duckduckgo/apple-browsers/pull/4668), `FeatureFlag.swift:635`
|
||||
|
||||
**Issue:** Same commented-out `Config(...)` dead code flagged by Bugbot above. aataraxiaa also requests it be removed.
|
||||
|
||||
**State:** 🔴 [OPEN] on GitHub. Not yet fixed.
|
||||
**State:** ⭕ TODO — GitHub thread [OPEN]. Deferred until #4544 is done.
|
||||
|
||||
---
|
||||
|
||||
### 🔴 PR #4668 — Bugbot (BrowserChromeManager.swift:43): New protocol method no callers
|
||||
### 🔴 PR #4668 — Bugbot (BrowserChromeManager.swift:43) `r3234513817`: New protocol method no callers
|
||||
|
||||
**Source:** Bugbot on PR #4668, `BrowserChromeManager.swift:43`
|
||||
|
||||
**Issue:** `embedInUnifiedInputEditingAreaIfActive` added to `BrowserChromeDelegate` protocol and implemented in `BrowserChromeManager`, but no caller exists anywhere in the codebase.
|
||||
**Issue:** `embedInUnifiedInputEditingAreaIfActive` added to `BrowserChromeDelegate` protocol and implemented, but no caller exists. The NTP's `embedDialogInEditingState` and `showDuckAIOnboardingCompletionDialogInUTI` both embed by casting `parent as? MainViewController` directly instead of going through this protocol method. Additionally the **implementations differ**: the protocol method pins to `navigationBarContainer.bottomAnchor`, while actual NTP embedding pins to `coordinator.viewController.view.bottomAnchor`. So simply adding a caller is not enough — implementations must be aligned first.
|
||||
|
||||
**State:** On `sr-feedback` branch commit `82bb0f71e3` removed `embedDialogInEditingState` dead code; the protocol method may now be entirely unreachable. **Needs verification on #4668 branch.** GitHub thread NOT resolved. → Either add a caller or remove the method and its implementation.
|
||||
**State:** 🔴 [OPEN] on GitHub. Deferred until #4544 is done. Fix = align implementations + wire caller, or remove the protocol method entirely.
|
||||
|
||||
---
|
||||
|
||||
|
||||
Reference in New Issue
Block a user