git_admin/obsidian-vault
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[2026-05-15] media-toolbox-kraken: сессия 10, 23 unresolved, 0 errors

Browse Source
This commit is contained in:
Alexey Martemyanov
2026-05-15 18:53:05 +06:00
parent fb246871ce
commit 104782dca9
2 changed files with 92 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
work/wiki/apple-browsers/chat-path-onboarding-tracker-blocking.md
+18 -2
View File
@@ -131,11 +131,15 @@ This is the same bug as **PR #4544 — Bugbot r3234645543** below. Fix is in `di
- `iOS/DuckDuckGo/MainViewController.swift`
- `iOS/DuckDuckGo/NewTabPageControllerDelegate.swift`
- `iOS/DuckDuckGo/NewTabPageViewController.swift`
- `iOS/DuckDuckGo/OnboardingFlow/LinearOnboarding/OnboardingIntroViewModel.swift` — also needs `!restorePromptHandler.isEligibleForRestorePrompt()` added (see PR #4855 Alessandro line 450)
- `iOS/DuckDuckGo/OnboardingFlow/LinearOnboarding/OnboardingIntroViewModel.swift` — returning-user guard uncommented; `!restorePromptHandler.isEligibleForRestorePrompt()` added
- `iOS/DuckDuckGo/OnboardingView+DuckAIExperimentSearchContent.swift` — label currently "Ask AI", needs correction to **"Ask.ai"** (with dot)
- `iOS/DuckDuckGo/UserText.swift` + all 26 lproj files
- `iOS/DuckDuckGo/MainViewController.swift` — subscription promo keyboard fix; `navigateFromOnboarding` bar animation
- `iOS/DuckDuckGo/DaxDialogs.swift` — visit-site restore-on-relaunch fix
- `iOS/DuckDuckGo/NewTabPageViewController.swift` — bar animation on dismiss; loading-check removal
- `iOS/DuckDuckGo/NewTabPageControllerDelegate.swift` — `newTabPageControllerCurrentTabIsLoading` removed
**Action:** Fix "Ask.ai" copy + add `isEligibleForRestorePrompt` guard, then commit and push before #4855 can be reviewed.
**Action:** Fix "Ask.ai" copy, then commit and push before #4855 can be reviewed.
> **Color legend:** 🟠 fix in working tree, uncommitted — 🟡 fix in another PR in stack, not merged to this one — 🔴 not fixed / blocked — ✅ done
@@ -514,6 +518,18 @@ All resolved on GitHub. Fixed in later commits on the `#4544` branch.
---
### 🟠 BUG-1 — Subscription promo hidden by keyboard-on-new-tab when reopened after restart
**Source:** Found during testing.
**Issue:** `attachHomeScreen(isNewTab:allowingKeyboard:)` calls `omniBar.beginEditing(animated: true)` when `KeyboardSettings().onNewTab` is enabled. This runs synchronously before the NTP's `viewDidAppear`, which is where `presentNextDaxDialog` shows the subscription promo. The editing state created by `beginEditing` immediately covers the dialog.
**Fix:** Added `!daxDialogsManager.subscriptionPromotionPending` guard to the `beginEditing` call in `attachHomeScreen`. `subscriptionPromotionPending` is `true` only when the promo is eligible, not yet shown, and the main onboarding flow is complete.
**State:** `sr-feedback / uncommitted` — fix in working tree.
---
### 🟠 DEAD-1 — `setChatPathVisitSiteControlsLocked` in `MainViewController+DuckAIExperiment.swift:166` is dead code
**Source:** Callers removed as part of PR #4855 Alessandro (line 477) fix above.