[2026-11-19] eagle: work/zoom-transcripts/2026-10-19 Michal Smaga's Personal Meeting Room QvxllpCuTTSLGEZp-R6jQw/transcript.json work/zoom-transcripts/2026-10-19 Michal Smaga's Personal Meeting Room QvxllpCuTTSLGEZp-R6jQw/transcript.md work/zoom-transcripts/index.json work/zoom-transcripts/sync-status.json
This commit is contained in:
1 parent
3901dc37d7
commit
0d0e464c2b
4 files changed
+783
-3
No files matched your search
+650
@@ -23,6 +23,656 @@
|
|||||||
"time": "18:10:09",
|
"time": "18:10:09",
|
||||||
"speaker": "Michal Smaga",
|
"speaker": "Michal Smaga",
|
||||||
"text": "Uh, I think I'm, I'm like… done reviewing the first one about the pixel. I had the issue that I wasn't able to reproduce it, like, I was trying to kill the WebKit process."
|
"text": "Uh, I think I'm, I'm like… done reviewing the first one about the pixel. I had the issue that I wasn't able to reproduce it, like, I was trying to kill the WebKit process."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:10:22",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Mm-hmm."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:10:23",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Do you have any, like, extra steps?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:10:27",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Uh, so generally it fails from the second try on this exact test page that is attached there."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:10:37",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "So after, after I, I killed the, the, the…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:10:37",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Okay."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:10:41",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Web extension, web process. I should reload the page?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:10:47",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Yes, in general."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:10:49",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Do I need to do it, like, quickly, or do I need to, like…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:10:53",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Um…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:10:53",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Wait a bit."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:10:55",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Usually… yeah. I don't know, within one second, just kill the process, then reload the page."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:11:02",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:11:03",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "If it doesn't work from the first try, you just give it and reload again, and usually from second attempt, it does, uh… Uh, hang the… the extension. So it's not… it's not the genuine issue, so it's the…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:11:20",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah, artificial."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:11:22",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "artificial reproducing step that we didn't enable with the feature flag of the fix that went before, but it should be still here, and we… and allow to… To produce it. Uh, that's… So generally, yeah, I think you've seen the comment I posted to… to the… Project communication task. And the data, the data analysis."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:11:52",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah, yeah, yeah."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:11:52",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "So… so generally there is, uh… yeah, it's kind of heavy codecs and cloud work, and, um… I cannot… Oh. I cannot tell that I understand, like, 100% what is happening beneath, uh, under the hood, and… Um… Generally, we have reproduced most of the… of the stall issues, uh, with some… Thank you. my display on black. Wow. I just need to switch off something, I guess."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:12:35",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "I can hear you, I cannot see you."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:12:36",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Hello? Yeah, I cannot see you, because… Give it a minute. Yeah. No. Fuck. And… Good morning, Mark. Sorry. One moment, Amy. I need to burn off something."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:13:10",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Did your laptop display died?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:13:13",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Not yet, I guess. I hope. Uh, here… Here we are. Uh-huh. So, we do. Yeah. All right, I'm back. And… Oh, yeah, I just got some. Testing. Fairness around here. Uh, where was I? Yeah, the issues. Uh, so generally, there's four issues in the work, and uh… One is behind the disabled feature flag. Because it reloads the page, and I don't think it's optimal. And probably a couple of more go next, and we'll leave. the smallest groups for the next iteration, I guess. So here we have to, uh… To expand the diagnostics. So generally, to fulfill the privacy triage, uh, I was requested to… To reduce what we… actually submit, and the decision was to merge the events into a single event. It should not generally harm our, uh… our data. We can lose something in case the browser crashes, or if it's reloaded. But I guess it's acceptable at this point, since we get these isolated groups already. And we just need some proofs. for the remaining and the pixels. Prior to this."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:15:02",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yes. So, so the first…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:15:04",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Pixel fire for the pixel, yeah."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:15:06",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "First PR is the pixels, yeah? So the one from the PR."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:15:09",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Yes, so the suggestion is to improve the diagnostics first, and then the stacked ones go onto it."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:15:18",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah, and what is the status of the other, like, PRs, the follow-up ones, with the fixes?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:15:24",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Uh, so we have the… the recovery. And… First one is InitLoss. And InitLoss includes P1 and P2 as inputs. As I remember. Yeah, and P4, that's not enabled at the moment. It's, uh, 7379. It should be… Should be generated already. For review. And another one is 7459. It's also open. And… Well, generally, should also be pretty much ready, so the… There is integration tests, integration test harness that's supposed to only be run once to reproduce the issue."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:16:38",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Mm-hmm."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:16:39",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "In, like, lab condition."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:16:40",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Can you say. Which one was the last PR?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:16:45",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "The last one, uh, 7459. This one."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:17:00",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah, yeah, yeah, I got it, yeah, the network one, yeah."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:17:11",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "So the first, that is 7379, it should… So basically, we guess that it may be not an issue. And it's maybe an issue of slow. Slow loading and the fix itself is triggering the background will be load with the navigation itself. Because, uh, the initial… initial startup, or return from background, maybe not, uh, warming up the web view. Or, um… Or our extension. And, uh… The situation with P4 is that we may need to reload the page after, you know, after the extension is loaded, so it is applied to the page. And, uh, I was planning to investigate it further. Is there a way to run the… Plug in after the page is already loaded, maybe send another page load event. And see if it… if it just works. Uh, but the reload is there. And the feature flag."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:18:36",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "And do you think, like, uh… Are we able to detect the fourth one without the feature flag? Just to get the pixels about, like, how…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:18:48",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Just to get the pixels… yeah, I guess so. I guess so we can make the pixel."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:18:59",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah, because it would be get, like. It's good to get the signal, like, how many of those cases they potentially would be fixed by the future flag."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:19:11",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Yeah, I agree."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:19:12",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah, but I mean, like, reloading the page is kind of, like, a risky thing, yeah, it can be disruptive, and… The question is, like, how frequently it would be."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:19:22",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Mm-hmm."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:19:23",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah, and probably we would also have, like, the question is, like, how much confidence that they are actually, like, experiencing the problem. Just not to do the the, like, the reload. When there's no… not an issue for that."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:19:57",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Okay, and the next one is the network. Network process crash. Uh, it's a bit trickier. I… I didn't finish going through it. Actually… But, uh… So general state of it, it's kind of reproduced on the integration test harness. And the fix… Seems… to fix it. So, again, it's kinda… not… non-proved concepts and kind of speculative fixes. And we are hoping to… So first of all, those should be feature flagged, just in case anything goes wrong with it. You can private selectors or whatever are disturbing. The overall extension flow, so we could disable it remotely, and uh… Yeah, so again, I'm… Oh… Not 100% sure on those, but how it is reproduced in the test harness and by the automation. It seems we could use those fixes. Another one pending, it's not opened yet, is the base URL thing. And, uh… And the speculative steps to reproduce is, uh, if we reload the, um… if we update the web extension. it changes the base URL. Because we don't have this table base irrelevant. Those… It was flagged in the early research phase. Uh, what I'm not sure with it, uh, does it harm any… Can it bring any privacy or security concerns with it if we…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:22:09",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "But which base? I, I don't, I don't get it, like, fully, like, with me."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:22:13",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "The extension was 0. So it's UUID that's generated for the extension every time it's launched. And when it changes, it brings some… Disturbance into the web extension."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:22:28",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Okay."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:22:29",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "And if we set it fixed as a fixed UID. For our web extension, it generally follows the WebKit rules as I understand it and may fix another part of the failures."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:22:44",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Mhmm. But it's only only on update, like, when we uninstall and install again, right?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:22:45",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "And, uh… Yeah, but I, uh… I can guess it may be some significant portion of users that receive the service related to the app updates. As, uh, as it was, uh, as it was… described and issued initially."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:23:14",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Okay, so it's like, uh… 3… Three PRs with fixes. and potentially four."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:23:24",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Mmhm. network, the P1 one, uh, base URL. One for the loading. And, uh, yeah, potentially the fifth one. So, yeah, currently there is four, uh, four fixes in… in my… On my… work."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:23:53",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "So, do you have any, like, doubts, like, that, like, some of the fixes are, like, too risky, and, like, for example, the reload one? you would be not too sure about, like, shipping that one? Because I'm just, like, thinking…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:24:05",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Uh, Zip?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:24:07",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "thinking about, like, probably we can have the questions from Russell or someone, like. How much more time we can spend here, like, just to, like, focus on the, like, bare minimum, because probably, like, just to, like… better calculate the effort that we want to put into it."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:24:27",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Yeah, generally, we already had this question by Russell, as I mentioned, and I tried to answer it today."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:24:30",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah, yeah, yeah."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:24:37",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "No, we've seen it. Uh, so the issue here is, uh, that we cannot distribute. the failures. You cannot tell there is one main… ah, yeah, there is another. Another one… And… Great deeds. Yeah, another genuine one that is kind of proved is window git close. So the original. Window and tab merging management, uh, fix it, uh… It didn't cover every… Every issue with the pin tab, and there is still one more remaining, uh, for the window closing, and, uh, yeah, should be a short one. Uh, it should cover the genuine issue of closing in tab using the web extension."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:25:31",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "But it's only McCoy, right?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:25:32",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "I don't know. Yeah, my question. So, yeah, that is, uh, for… Four, one, two, three, one, two, three, four main groups that are targeted here, one requiring the page reload. And the P3 that, uh, without… Context without view, it may be the pin tab. And we have one iOS of 0.03%. macOS at around 6%, but it may be wrong. And we have the other group that cannot be considered at the moment. Maybe it gets fixed with the four fixes, or maybe we receive some more data. So I try to express this point in the conversation task. But if the hypothesis are correct, we should cover most of the cases."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:26:37",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "So, do you estimate to get them done this week?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:26:37",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "So, yeah. Yeah, so the point here is to timebox it to…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:26:45",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "To merge it this week, and so we can, like, get it internally next week, right?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:26:45",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Two currents. Yeah. Yeah, so if we… if we get it to the release… I mean, the data analysis, the data attribution extension, and those fixes, if we get it to internal. Today and tomorrow. Uh, we can reason about it on… Next week."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:27:11",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Okay, so you would mean to merge it to… Release branches."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:27:17",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Yes, if it's possible."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:27:22",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "So, the two first PRs, like, one for the telemetry for the pixels, and the second with the P1 and P2, right?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:27:31",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Um… It depends, I guess, if we can do it, if it's possible, I would give a go for all of them. Again, behind the feature flags."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:27:43",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah, let's try. So, like, I'm… I'm… I'm… I'm done, like… reading and commenting for the first PRs, there are a couple of, like. leftovers for the dead code, so please check the comments. I'll try to, like, try forcing to reproduce it."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:27:55",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Mmhm."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:28:01",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "So so I get it and then I can move to the next PR. I can focus today on that. So we have the the the chart."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:28:08",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Okay, good. And when we have those reviewed, we can open the exception and try to push it to the internal."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:28:18",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "I mean, like, if it's, like, Monday, Tuesday, you can do it probably, like, for free."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:28:24",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Mm-hmm, okay."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:28:24",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "If it's later than tomorrow. Yeah. Okay. Okay, so let's try to do that."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:28:30",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Okay, I'll… I'll keep you pinged, yeah."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:28:31",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "And… Please ping me when you have the following one, because I want to, like…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:28:37",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Mm-hmm."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:28:38",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Schedule the time for them, uh, like, in between my, my work, just to, just to not, like… Delay you. Uh, yeah."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:28:47",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Yeah, I guess it's… I guess it may take some time, maybe the rest of your day today, and those two PRs. Could feel it."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:28:58",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah, so I'll focus on that, not to block you, so let's push for the first two ones, and yeah."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:29:04",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Mmhm."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:29:04",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "And the others, like, later in the week."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:29:07",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Mm-hmm."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:29:08",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah, I agree."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:29:09",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "So, and yeah."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:29:10",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Just to try to get them out as soon as possible to get some results."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:29:16",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "And yes, since it's highly speculative, I would give it another mid-mortem. So yeah, time box it to this week. I'd say to the first half of this week. Because there is not much work really to be done about it. Just, uh… Just so you know, I have, like, a huge testing harness work tree, and I'm trying to split the parts from it that reproduce one another issue and make it into…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:29:48",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "No doubt."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:29:53",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "into digestible pull requests. But generally, most of them are kind of reproduced in the lab. But we have no any proofs that they actually match the production issues because they are based on the event sequence that we get."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:30:08",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:30:14",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "We got to produce the event sequence that we are receiving, but we still cannot reason about the real issues leading to those. So, yeah, that's the state. All right, thank you. I won't take more of your time."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:30:31",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "So, after this week, you would put the, like, you would have the mid-mortem this week, or, like, next week after the…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:30:41",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Next week, so let's try to get it out and have some data. The meeting is on Tuesday, right? So we could have the data analyzed and, uh, have a mid-mortem. and decide on the next steps whether we need. Keep on going, or we are satisfied with those, or we just give up and…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:31:06",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah. But do you think, like, on Tuesday, you will have, like, any meaningful data? It will be, like, just out for two days. Right?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:31:13",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Uh, yes, we should, uh, since we… we received most of the current data by Tuesday. And it didn't change significantly throughout the week. I think there is a lot of issues are reported."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:31:36",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Okay."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:31:37",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "And there's more than enough data to analyze. So, yeah, Tuesday should be should be fine to have a big more time. I'll probably update the comments. Highlighting this."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:31:51",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Okay, sounds good. Okay, so I'm back to reviewing it, and, like, let's… Probably tomorrow you can, like, will you be on the OE weekly?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:32:05",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Yes, tomorrow, tomorrow, tomorrow, tomorrow is Tuesday, yes, I think so."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:32:11",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah, so we can recap the plan and see. So this is, like, your top priority, right? You're focusing on…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:32:20",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Yeah, yeah. So, I mean, there is, uh, there is enough work for me outside of the top priority. Like where you are and pushing other stuff forward. But, yeah."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:32:39",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Makes sense. Cool. Are you blocked by anything, or just, like, this is, like… The general, like, work is enough for you."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:32:49",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Alright. Blocked with the data missing. And, uh, so… Only the pull requests are on the plate. Bottle making it. And, uh, yeah, the gaps between the releases, so we… keep perceiving it and. Analyzing how it goes."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:33:11",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Have you assigned me to all of the PRs? Because, uh, I see them…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:33:15",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Not yet, I guess. Let me assign the network process. I didn't go through it myself yet, but yeah, I've assigned it to you."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:33:29",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Yeah, I think, like, something is broken with the…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:33:33",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Yeah, yeah, I'll… I'm on it."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:33:36",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "No, no, like, I mean, like, uh, I'm browsing through the, the, this PR, these are the PRs, and, like, I'm filtering by the assigned to me. And I only picked it up."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:33:47",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Ah, assignees. I need to assign them. We generally don't assign the PRs, just set a reviewer."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:33:54",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "I don't know, like, you have the filter, like, review requested."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:00",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Mm-hmm."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:01",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "They can…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:01",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Yeah, let me just send. Yes, I need. and requests. Yeah, so there is three pull requests."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:07",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Can you… can you see? So those are, like, open PRs from you all, but you have the filter for review, and it's, like, awaiting review from…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:14",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Yep."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:18",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Me? I only get two of them."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:24",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Okay. 7, 4, 5, 5, 7."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:26",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Which is weird."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:29",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Oh, 7376 is missing for some reason. Probably you gave a review for it already. And it's waiting for…"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:38",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Okay."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:40",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "For the resolutions. Angus."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:43",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Okay, so maybe it's like, yeah."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:46",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Yeah, so currently two more in stock."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:50",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Okay. So it's it's in the stack, so I can get them from from the list. Right?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:55",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Yep."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:56",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Okay, cool. Can I help you in any other way?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:34:59",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Review stuck. Yes, stuck, stuck, stuck. Create stuck. Create stuck. And now those are in the stacks. Okay, good."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:35:15",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Do you need any other help?"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:35:18",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Not at the moment. I'm going to update the first one, telemetry one. And give you a ping, and uh… And when I complete the third one, I'll ping you as well, and probably… Probably the window did close, should be an easy one for today. As well. If it sounds good."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:35:46",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Okay. Okay, so I'm on the PRs. Please check the comments for the first one. I'm all moving for the second one."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:35:58",
|
||||||
|
"speaker": "Alex Martemyanov",
|
||||||
|
"text": "Sure. Okay, thank you."
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"time": "18:36:03",
|
||||||
|
"speaker": "Michal Smaga",
|
||||||
|
"text": "Thank you."
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
}
|
}
|
||||||
+130
@@ -15,3 +15,133 @@ source: "https://us01mynotes.zoom.us/QvxllpCuTTSLGEZp-R6jQw"
|
|||||||
- **18:10:01 · Michal Smaga:** Good.
|
- **18:10:01 · Michal Smaga:** Good.
|
||||||
- **18:10:01 · Alex Martemyanov:** I'm pretty good. Jumping between windows. Yes.
|
- **18:10:01 · Alex Martemyanov:** I'm pretty good. Jumping between windows. Yes.
|
||||||
- **18:10:09 · Michal Smaga:** Uh, I think I'm, I'm like… done reviewing the first one about the pixel. I had the issue that I wasn't able to reproduce it, like, I was trying to kill the WebKit process.
|
- **18:10:09 · Michal Smaga:** Uh, I think I'm, I'm like… done reviewing the first one about the pixel. I had the issue that I wasn't able to reproduce it, like, I was trying to kill the WebKit process.
|
||||||
|
- **18:10:22 · Alex Martemyanov:** Mm-hmm.
|
||||||
|
- **18:10:23 · Michal Smaga:** Do you have any, like, extra steps?
|
||||||
|
- **18:10:27 · Alex Martemyanov:** Uh, so generally it fails from the second try on this exact test page that is attached there.
|
||||||
|
- **18:10:37 · Michal Smaga:** So after, after I, I killed the, the, the…
|
||||||
|
- **18:10:37 · Alex Martemyanov:** Okay.
|
||||||
|
- **18:10:41 · Michal Smaga:** Web extension, web process. I should reload the page?
|
||||||
|
- **18:10:47 · Alex Martemyanov:** Yes, in general.
|
||||||
|
- **18:10:49 · Michal Smaga:** Do I need to do it, like, quickly, or do I need to, like…
|
||||||
|
- **18:10:53 · Alex Martemyanov:** Um…
|
||||||
|
- **18:10:53 · Michal Smaga:** Wait a bit.
|
||||||
|
- **18:10:55 · Alex Martemyanov:** Usually… yeah. I don't know, within one second, just kill the process, then reload the page.
|
||||||
|
- **18:11:02 · Michal Smaga:** Yeah.
|
||||||
|
- **18:11:03 · Alex Martemyanov:** If it doesn't work from the first try, you just give it and reload again, and usually from second attempt, it does, uh… Uh, hang the… the extension. So it's not… it's not the genuine issue, so it's the…
|
||||||
|
- **18:11:20 · Michal Smaga:** Yeah, artificial.
|
||||||
|
- **18:11:22 · Alex Martemyanov:** artificial reproducing step that we didn't enable with the feature flag of the fix that went before, but it should be still here, and we… and allow to… To produce it. Uh, that's… So generally, yeah, I think you've seen the comment I posted to… to the… Project communication task. And the data, the data analysis.
|
||||||
|
- **18:11:52 · Michal Smaga:** Yeah, yeah, yeah.
|
||||||
|
- **18:11:52 · Alex Martemyanov:** So… so generally there is, uh… yeah, it's kind of heavy codecs and cloud work, and, um… I cannot… Oh. I cannot tell that I understand, like, 100% what is happening beneath, uh, under the hood, and… Um… Generally, we have reproduced most of the… of the stall issues, uh, with some… Thank you. my display on black. Wow. I just need to switch off something, I guess.
|
||||||
|
- **18:12:35 · Michal Smaga:** I can hear you, I cannot see you.
|
||||||
|
- **18:12:36 · Alex Martemyanov:** Hello? Yeah, I cannot see you, because… Give it a minute. Yeah. No. Fuck. And… Good morning, Mark. Sorry. One moment, Amy. I need to burn off something.
|
||||||
|
- **18:13:10 · Michal Smaga:** Did your laptop display died?
|
||||||
|
- **18:13:13 · Alex Martemyanov:** Not yet, I guess. I hope. Uh, here… Here we are. Uh-huh. So, we do. Yeah. All right, I'm back. And… Oh, yeah, I just got some. Testing. Fairness around here. Uh, where was I? Yeah, the issues. Uh, so generally, there's four issues in the work, and uh… One is behind the disabled feature flag. Because it reloads the page, and I don't think it's optimal. And probably a couple of more go next, and we'll leave. the smallest groups for the next iteration, I guess. So here we have to, uh… To expand the diagnostics. So generally, to fulfill the privacy triage, uh, I was requested to… To reduce what we… actually submit, and the decision was to merge the events into a single event. It should not generally harm our, uh… our data. We can lose something in case the browser crashes, or if it's reloaded. But I guess it's acceptable at this point, since we get these isolated groups already. And we just need some proofs. for the remaining and the pixels. Prior to this.
|
||||||
|
- **18:15:02 · Michal Smaga:** Yes. So, so the first…
|
||||||
|
- **18:15:04 · Alex Martemyanov:** Pixel fire for the pixel, yeah.
|
||||||
|
- **18:15:06 · Michal Smaga:** First PR is the pixels, yeah? So the one from the PR.
|
||||||
|
- **18:15:09 · Alex Martemyanov:** Yes, so the suggestion is to improve the diagnostics first, and then the stacked ones go onto it.
|
||||||
|
- **18:15:18 · Michal Smaga:** Yeah, and what is the status of the other, like, PRs, the follow-up ones, with the fixes?
|
||||||
|
- **18:15:24 · Alex Martemyanov:** Uh, so we have the… the recovery. And… First one is InitLoss. And InitLoss includes P1 and P2 as inputs. As I remember. Yeah, and P4, that's not enabled at the moment. It's, uh, 7379. It should be… Should be generated already. For review. And another one is 7459. It's also open. And… Well, generally, should also be pretty much ready, so the… There is integration tests, integration test harness that's supposed to only be run once to reproduce the issue.
|
||||||
|
- **18:16:38 · Michal Smaga:** Mm-hmm.
|
||||||
|
- **18:16:39 · Alex Martemyanov:** In, like, lab condition.
|
||||||
|
- **18:16:40 · Michal Smaga:** Can you say. Which one was the last PR?
|
||||||
|
- **18:16:45 · Alex Martemyanov:** The last one, uh, 7459. This one.
|
||||||
|
- **18:17:00 · Michal Smaga:** Yeah, yeah, yeah, I got it, yeah, the network one, yeah.
|
||||||
|
- **18:17:11 · Alex Martemyanov:** So the first, that is 7379, it should… So basically, we guess that it may be not an issue. And it's maybe an issue of slow. Slow loading and the fix itself is triggering the background will be load with the navigation itself. Because, uh, the initial… initial startup, or return from background, maybe not, uh, warming up the web view. Or, um… Or our extension. And, uh… The situation with P4 is that we may need to reload the page after, you know, after the extension is loaded, so it is applied to the page. And, uh, I was planning to investigate it further. Is there a way to run the… Plug in after the page is already loaded, maybe send another page load event. And see if it… if it just works. Uh, but the reload is there. And the feature flag.
|
||||||
|
- **18:18:36 · Michal Smaga:** And do you think, like, uh… Are we able to detect the fourth one without the feature flag? Just to get the pixels about, like, how…
|
||||||
|
- **18:18:48 · Alex Martemyanov:** Just to get the pixels… yeah, I guess so. I guess so we can make the pixel.
|
||||||
|
- **18:18:59 · Michal Smaga:** Yeah, because it would be get, like. It's good to get the signal, like, how many of those cases they potentially would be fixed by the future flag.
|
||||||
|
- **18:19:11 · Alex Martemyanov:** Yeah, I agree.
|
||||||
|
- **18:19:12 · Michal Smaga:** Yeah, but I mean, like, reloading the page is kind of, like, a risky thing, yeah, it can be disruptive, and… The question is, like, how frequently it would be.
|
||||||
|
- **18:19:22 · Alex Martemyanov:** Mm-hmm.
|
||||||
|
- **18:19:23 · Michal Smaga:** Yeah, and probably we would also have, like, the question is, like, how much confidence that they are actually, like, experiencing the problem. Just not to do the the, like, the reload. When there's no… not an issue for that.
|
||||||
|
- **18:19:57 · Alex Martemyanov:** Okay, and the next one is the network. Network process crash. Uh, it's a bit trickier. I… I didn't finish going through it. Actually… But, uh… So general state of it, it's kind of reproduced on the integration test harness. And the fix… Seems… to fix it. So, again, it's kinda… not… non-proved concepts and kind of speculative fixes. And we are hoping to… So first of all, those should be feature flagged, just in case anything goes wrong with it. You can private selectors or whatever are disturbing. The overall extension flow, so we could disable it remotely, and uh… Yeah, so again, I'm… Oh… Not 100% sure on those, but how it is reproduced in the test harness and by the automation. It seems we could use those fixes. Another one pending, it's not opened yet, is the base URL thing. And, uh… And the speculative steps to reproduce is, uh, if we reload the, um… if we update the web extension. it changes the base URL. Because we don't have this table base irrelevant. Those… It was flagged in the early research phase. Uh, what I'm not sure with it, uh, does it harm any… Can it bring any privacy or security concerns with it if we…
|
||||||
|
- **18:22:09 · Michal Smaga:** But which base? I, I don't, I don't get it, like, fully, like, with me.
|
||||||
|
- **18:22:13 · Alex Martemyanov:** The extension was 0. So it's UUID that's generated for the extension every time it's launched. And when it changes, it brings some… Disturbance into the web extension.
|
||||||
|
- **18:22:28 · Michal Smaga:** Okay.
|
||||||
|
- **18:22:29 · Alex Martemyanov:** And if we set it fixed as a fixed UID. For our web extension, it generally follows the WebKit rules as I understand it and may fix another part of the failures.
|
||||||
|
- **18:22:44 · Michal Smaga:** Mhmm. But it's only only on update, like, when we uninstall and install again, right?
|
||||||
|
- **18:22:45 · Alex Martemyanov:** And, uh… Yeah, but I, uh… I can guess it may be some significant portion of users that receive the service related to the app updates. As, uh, as it was, uh, as it was… described and issued initially.
|
||||||
|
- **18:23:14 · Michal Smaga:** Okay, so it's like, uh… 3… Three PRs with fixes. and potentially four.
|
||||||
|
- **18:23:24 · Alex Martemyanov:** Mmhm. network, the P1 one, uh, base URL. One for the loading. And, uh, yeah, potentially the fifth one. So, yeah, currently there is four, uh, four fixes in… in my… On my… work.
|
||||||
|
- **18:23:53 · Michal Smaga:** So, do you have any, like, doubts, like, that, like, some of the fixes are, like, too risky, and, like, for example, the reload one? you would be not too sure about, like, shipping that one? Because I'm just, like, thinking…
|
||||||
|
- **18:24:05 · Alex Martemyanov:** Uh, Zip?
|
||||||
|
- **18:24:07 · Michal Smaga:** thinking about, like, probably we can have the questions from Russell or someone, like. How much more time we can spend here, like, just to, like, focus on the, like, bare minimum, because probably, like, just to, like… better calculate the effort that we want to put into it.
|
||||||
|
- **18:24:27 · Alex Martemyanov:** Yeah, generally, we already had this question by Russell, as I mentioned, and I tried to answer it today.
|
||||||
|
- **18:24:30 · Michal Smaga:** Yeah, yeah, yeah.
|
||||||
|
- **18:24:37 · Alex Martemyanov:** No, we've seen it. Uh, so the issue here is, uh, that we cannot distribute. the failures. You cannot tell there is one main… ah, yeah, there is another. Another one… And… Great deeds. Yeah, another genuine one that is kind of proved is window git close. So the original. Window and tab merging management, uh, fix it, uh… It didn't cover every… Every issue with the pin tab, and there is still one more remaining, uh, for the window closing, and, uh, yeah, should be a short one. Uh, it should cover the genuine issue of closing in tab using the web extension.
|
||||||
|
- **18:25:31 · Michal Smaga:** But it's only McCoy, right?
|
||||||
|
- **18:25:32 · Alex Martemyanov:** I don't know. Yeah, my question. So, yeah, that is, uh, for… Four, one, two, three, one, two, three, four main groups that are targeted here, one requiring the page reload. And the P3 that, uh, without… Context without view, it may be the pin tab. And we have one iOS of 0.03%. macOS at around 6%, but it may be wrong. And we have the other group that cannot be considered at the moment. Maybe it gets fixed with the four fixes, or maybe we receive some more data. So I try to express this point in the conversation task. But if the hypothesis are correct, we should cover most of the cases.
|
||||||
|
- **18:26:37 · Michal Smaga:** So, do you estimate to get them done this week?
|
||||||
|
- **18:26:37 · Alex Martemyanov:** So, yeah. Yeah, so the point here is to timebox it to…
|
||||||
|
- **18:26:45 · Michal Smaga:** To merge it this week, and so we can, like, get it internally next week, right?
|
||||||
|
- **18:26:45 · Alex Martemyanov:** Two currents. Yeah. Yeah, so if we… if we get it to the release… I mean, the data analysis, the data attribution extension, and those fixes, if we get it to internal. Today and tomorrow. Uh, we can reason about it on… Next week.
|
||||||
|
- **18:27:11 · Michal Smaga:** Okay, so you would mean to merge it to… Release branches.
|
||||||
|
- **18:27:17 · Alex Martemyanov:** Yes, if it's possible.
|
||||||
|
- **18:27:22 · Michal Smaga:** So, the two first PRs, like, one for the telemetry for the pixels, and the second with the P1 and P2, right?
|
||||||
|
- **18:27:31 · Alex Martemyanov:** Um… It depends, I guess, if we can do it, if it's possible, I would give a go for all of them. Again, behind the feature flags.
|
||||||
|
- **18:27:43 · Michal Smaga:** Yeah, let's try. So, like, I'm… I'm… I'm… I'm done, like… reading and commenting for the first PRs, there are a couple of, like. leftovers for the dead code, so please check the comments. I'll try to, like, try forcing to reproduce it.
|
||||||
|
- **18:27:55 · Alex Martemyanov:** Mmhm.
|
||||||
|
- **18:28:01 · Michal Smaga:** So so I get it and then I can move to the next PR. I can focus today on that. So we have the the the chart.
|
||||||
|
- **18:28:08 · Alex Martemyanov:** Okay, good. And when we have those reviewed, we can open the exception and try to push it to the internal.
|
||||||
|
- **18:28:18 · Michal Smaga:** I mean, like, if it's, like, Monday, Tuesday, you can do it probably, like, for free.
|
||||||
|
- **18:28:24 · Alex Martemyanov:** Mm-hmm, okay.
|
||||||
|
- **18:28:24 · Michal Smaga:** If it's later than tomorrow. Yeah. Okay. Okay, so let's try to do that.
|
||||||
|
- **18:28:30 · Alex Martemyanov:** Okay, I'll… I'll keep you pinged, yeah.
|
||||||
|
- **18:28:31 · Michal Smaga:** And… Please ping me when you have the following one, because I want to, like…
|
||||||
|
- **18:28:37 · Alex Martemyanov:** Mm-hmm.
|
||||||
|
- **18:28:38 · Michal Smaga:** Schedule the time for them, uh, like, in between my, my work, just to, just to not, like… Delay you. Uh, yeah.
|
||||||
|
- **18:28:47 · Alex Martemyanov:** Yeah, I guess it's… I guess it may take some time, maybe the rest of your day today, and those two PRs. Could feel it.
|
||||||
|
- **18:28:58 · Michal Smaga:** Yeah, so I'll focus on that, not to block you, so let's push for the first two ones, and yeah.
|
||||||
|
- **18:29:04 · Alex Martemyanov:** Mmhm.
|
||||||
|
- **18:29:04 · Michal Smaga:** And the others, like, later in the week.
|
||||||
|
- **18:29:07 · Alex Martemyanov:** Mm-hmm.
|
||||||
|
- **18:29:08 · Michal Smaga:** Yeah, I agree.
|
||||||
|
- **18:29:09 · Alex Martemyanov:** So, and yeah.
|
||||||
|
- **18:29:10 · Michal Smaga:** Just to try to get them out as soon as possible to get some results.
|
||||||
|
- **18:29:16 · Alex Martemyanov:** And yes, since it's highly speculative, I would give it another mid-mortem. So yeah, time box it to this week. I'd say to the first half of this week. Because there is not much work really to be done about it. Just, uh… Just so you know, I have, like, a huge testing harness work tree, and I'm trying to split the parts from it that reproduce one another issue and make it into…
|
||||||
|
- **18:29:48 · Michal Smaga:** No doubt.
|
||||||
|
- **18:29:53 · Alex Martemyanov:** into digestible pull requests. But generally, most of them are kind of reproduced in the lab. But we have no any proofs that they actually match the production issues because they are based on the event sequence that we get.
|
||||||
|
- **18:30:08 · Michal Smaga:** Yeah.
|
||||||
|
- **18:30:14 · Alex Martemyanov:** We got to produce the event sequence that we are receiving, but we still cannot reason about the real issues leading to those. So, yeah, that's the state. All right, thank you. I won't take more of your time.
|
||||||
|
- **18:30:31 · Michal Smaga:** So, after this week, you would put the, like, you would have the mid-mortem this week, or, like, next week after the…
|
||||||
|
- **18:30:41 · Alex Martemyanov:** Next week, so let's try to get it out and have some data. The meeting is on Tuesday, right? So we could have the data analyzed and, uh, have a mid-mortem. and decide on the next steps whether we need. Keep on going, or we are satisfied with those, or we just give up and…
|
||||||
|
- **18:31:06 · Michal Smaga:** Yeah. But do you think, like, on Tuesday, you will have, like, any meaningful data? It will be, like, just out for two days. Right?
|
||||||
|
- **18:31:13 · Alex Martemyanov:** Uh, yes, we should, uh, since we… we received most of the current data by Tuesday. And it didn't change significantly throughout the week. I think there is a lot of issues are reported.
|
||||||
|
- **18:31:36 · Michal Smaga:** Okay.
|
||||||
|
- **18:31:37 · Alex Martemyanov:** And there's more than enough data to analyze. So, yeah, Tuesday should be should be fine to have a big more time. I'll probably update the comments. Highlighting this.
|
||||||
|
- **18:31:51 · Michal Smaga:** Okay, sounds good. Okay, so I'm back to reviewing it, and, like, let's… Probably tomorrow you can, like, will you be on the OE weekly?
|
||||||
|
- **18:32:05 · Alex Martemyanov:** Yes, tomorrow, tomorrow, tomorrow, tomorrow is Tuesday, yes, I think so.
|
||||||
|
- **18:32:11 · Michal Smaga:** Yeah, so we can recap the plan and see. So this is, like, your top priority, right? You're focusing on…
|
||||||
|
- **18:32:20 · Alex Martemyanov:** Yeah, yeah. So, I mean, there is, uh, there is enough work for me outside of the top priority. Like where you are and pushing other stuff forward. But, yeah.
|
||||||
|
- **18:32:39 · Michal Smaga:** Makes sense. Cool. Are you blocked by anything, or just, like, this is, like… The general, like, work is enough for you.
|
||||||
|
- **18:32:49 · Alex Martemyanov:** Alright. Blocked with the data missing. And, uh, so… Only the pull requests are on the plate. Bottle making it. And, uh, yeah, the gaps between the releases, so we… keep perceiving it and. Analyzing how it goes.
|
||||||
|
- **18:33:11 · Michal Smaga:** Have you assigned me to all of the PRs? Because, uh, I see them…
|
||||||
|
- **18:33:15 · Alex Martemyanov:** Not yet, I guess. Let me assign the network process. I didn't go through it myself yet, but yeah, I've assigned it to you.
|
||||||
|
- **18:33:29 · Michal Smaga:** Yeah, I think, like, something is broken with the…
|
||||||
|
- **18:33:33 · Alex Martemyanov:** Yeah, yeah, I'll… I'm on it.
|
||||||
|
- **18:33:36 · Michal Smaga:** No, no, like, I mean, like, uh, I'm browsing through the, the, this PR, these are the PRs, and, like, I'm filtering by the assigned to me. And I only picked it up.
|
||||||
|
- **18:33:47 · Alex Martemyanov:** Ah, assignees. I need to assign them. We generally don't assign the PRs, just set a reviewer.
|
||||||
|
- **18:33:54 · Michal Smaga:** I don't know, like, you have the filter, like, review requested.
|
||||||
|
- **18:34:00 · Alex Martemyanov:** Mm-hmm.
|
||||||
|
- **18:34:01 · Michal Smaga:** They can…
|
||||||
|
- **18:34:01 · Alex Martemyanov:** Yeah, let me just send. Yes, I need. and requests. Yeah, so there is three pull requests.
|
||||||
|
- **18:34:07 · Michal Smaga:** Can you… can you see? So those are, like, open PRs from you all, but you have the filter for review, and it's, like, awaiting review from…
|
||||||
|
- **18:34:14 · Alex Martemyanov:** Yep.
|
||||||
|
- **18:34:18 · Michal Smaga:** Me? I only get two of them.
|
||||||
|
- **18:34:24 · Alex Martemyanov:** Okay. 7, 4, 5, 5, 7.
|
||||||
|
- **18:34:26 · Michal Smaga:** Which is weird.
|
||||||
|
- **18:34:29 · Alex Martemyanov:** Oh, 7376 is missing for some reason. Probably you gave a review for it already. And it's waiting for…
|
||||||
|
- **18:34:38 · Michal Smaga:** Okay.
|
||||||
|
- **18:34:40 · Alex Martemyanov:** For the resolutions. Angus.
|
||||||
|
- **18:34:43 · Michal Smaga:** Okay, so maybe it's like, yeah.
|
||||||
|
- **18:34:46 · Alex Martemyanov:** Yeah, so currently two more in stock.
|
||||||
|
- **18:34:50 · Michal Smaga:** Okay. So it's it's in the stack, so I can get them from from the list. Right?
|
||||||
|
- **18:34:55 · Alex Martemyanov:** Yep.
|
||||||
|
- **18:34:56 · Michal Smaga:** Okay, cool. Can I help you in any other way?
|
||||||
|
- **18:34:59 · Alex Martemyanov:** Review stuck. Yes, stuck, stuck, stuck. Create stuck. Create stuck. And now those are in the stacks. Okay, good.
|
||||||
|
- **18:35:15 · Michal Smaga:** Do you need any other help?
|
||||||
|
- **18:35:18 · Alex Martemyanov:** Not at the moment. I'm going to update the first one, telemetry one. And give you a ping, and uh… And when I complete the third one, I'll ping you as well, and probably… Probably the window did close, should be an easy one for today. As well. If it sounds good.
|
||||||
|
- **18:35:46 · Michal Smaga:** Okay. Okay, so I'm on the PRs. Please check the comments for the first one. I'm all moving for the second one.
|
||||||
|
- **18:35:58 · Alex Martemyanov:** Sure. Okay, thank you.
|
||||||
|
- **18:36:03 · Michal Smaga:** Thank you.
|
||||||
@@ -362,8 +362,8 @@
|
|||||||
"note_modified_at": "2026-10-19T12:37:38.903Z",
|
"note_modified_at": "2026-10-19T12:37:38.903Z",
|
||||||
"source_url": "https://us01mynotes.zoom.us/QvxllpCuTTSLGEZp-R6jQw",
|
"source_url": "https://us01mynotes.zoom.us/QvxllpCuTTSLGEZp-R6jQw",
|
||||||
"folder": "2026-10-19 Michal Smaga's Personal Meeting Room QvxllpCuTTSLGEZp-R6jQw",
|
"folder": "2026-10-19 Michal Smaga's Personal Meeting Room QvxllpCuTTSLGEZp-R6jQw",
|
||||||
"sha256": "5cf16938df6ebe0110bec8e8b4311fcbe55a764bd2bb72f64faa049ba1777d9e",
|
"sha256": "a4b3c5ce7fafb99496019591da19f9a103e35cf5f37ec42aa8f154021fdebcae",
|
||||||
"cues": 3
|
"cues": 133
|
||||||
},
|
},
|
||||||
"KcmYOq5_SQGPxdkdbhRx9A": {
|
"KcmYOq5_SQGPxdkdbhRx9A": {
|
||||||
"title": "Dominik Kapusta's Personal Meeting Room",
|
"title": "Dominik Kapusta's Personal Meeting Room",
|
||||||
|
|||||||
@@ -1 +1 @@
|
|||||||
{"observed_at":"2026-11-19T08:16:23.181Z","scanned":31,"imported":5,"skipped":26,"withoutTranscript":0,"coverage":"complete","sections":[{"name":"Owned by me","pages":5,"notes":86,"complete":true,"terminal_cursor":true},{"name":"Shared with me","pages":1,"notes":0,"complete":true,"terminal_cursor":true},{"name":"Starred","pages":1,"notes":0,"complete":true,"terminal_cursor":true}],"discovered":86,"gaps":[],"recovered_transcripts":0,"policy":"reread_all_owned_shared_and_starred_notes_since_cutoff","since":"2026-09-30"}
|
{"observed_at":"2026-11-19T08:37:58.448Z","scanned":31,"imported":1,"skipped":30,"withoutTranscript":0,"coverage":"complete","sections":[{"name":"Owned by me","pages":5,"notes":86,"complete":true,"terminal_cursor":true},{"name":"Shared with me","pages":1,"notes":0,"complete":true,"terminal_cursor":true},{"name":"Starred","pages":1,"notes":0,"complete":true,"terminal_cursor":true}],"discovered":86,"gaps":[],"recovered_transcripts":0,"policy":"reread_all_owned_shared_and_starred_notes_since_cutoff","since":"2026-09-30"}
|
||||||
Reference in new issue
Block a user